Ensure requirement_install_args is passed to macOS and iOS installs. - #2978
Merged
Conversation
Member
Author
|
@mhsmith Flagging for visibility - this was blocking dependabot updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2967 refactored the use of app requirements to use virtual environments to install requirements.
However, in doing this refactor, extra installer arguments were inadvertently omitted from the install process. This was observed as CI failures in Python-support-testbed (beeware/Python-support-testbed#192).
This ensures that the macOS and iOS invocations of requirements installs preserve the extra installer args.
Takes the opportunity to also switch back to rolling beeware/.github workflow pins, and to correct a permissions error with the dependabot changenote workflow.
PR Checklist: