Remove resources/ folder from app template - #274
Merged
Conversation
freakboy3742
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist:
Follows up on beeware/briefcase#3015, where it was confirmed that the resources/README's guidance (referencing files as "resources/filename") only works for Toga apps, via
App.paths.app. For Pygame, PySide6, and Console apps, which have no equivalent path-resolution mechanism, following this documented convention causes aFileNotFoundError, sincebriefcase devruns the app withcwdset to the user's home directory rather than the project directory.As suggested in the issue, this PR removes
{{ cookiecutter.app_name }}/src/{{ cookiecutter.module_name }}/resources/(containing only the README) from the base template.Fixes beeware/briefcase#3015.
Testing:
Confirmed no other file in the template (tests, pyproject.toml, packaging config) references the resources/ folder.
Full template test suite passes: 12 passed via tox.