Skip to content

Add Oliver-Leigh - #813

Merged
Oliver-Leigh merged 2 commits into
beeware:mainfrom
Oliver-Leigh:main
Jul 29, 2026
Merged

Add Oliver-Leigh#813
Oliver-Leigh merged 2 commits into
beeware:mainfrom
Oliver-Leigh:main

Conversation

@Oliver-Leigh

Copy link
Copy Markdown
Contributor

Add information about Oliver-Leigh to the website.

PR Checklist:

  • I will abide by the BeeWare Code of Conduct
  • I have read and have followed the CONTRIBUTING.md file
  • This PR was generated or assisted using an AI tool

Assisted-by:

@freakboy3742

Copy link
Copy Markdown
Member

Well that's annoying... looks like something is making email required field.... let's fix that...

@freakboy3742

Copy link
Copy Markdown
Member

Ah - you've opened this PR from main, so I can't push an update - but this will fix it:

diff --git a/docs/macros.py b/docs/macros.py
index 837165a48f..6d018e12b0 100644
--- a/docs/macros.py
+++ b/docs/macros.py
@@ -245,6 +245,10 @@ def define_env(env):
                         member_image_details_mastodon = ""
 
                     pronoun_logo, first_pronoun, second_pronoun = pronouns(member_details["pronoun"])
+                    try:
+                        member_email_details = f"""<div class="team-email" markdown="1">{fa("envelope", "lg", "solid")} <{member_details["email"]}></div>"""
+                    except KeyError:
+                        member_email_details = ""
 
                     member_image_details = dedent(
                         f"""\
@@ -256,7 +260,7 @@ def define_env(env):
                         <div class="team-pronouns" markdown="1">{fa("regular", pronoun_logo)} {first_pronoun}/{second_pronoun}</div>
                         <div class="team-github-handle" markdown="1">{fa("github", "lg", "brands")} [{github_id}](https://github.com/{github_id})</div>
                         {member_image_details_mastodon}
-                        <div class="team-email" markdown="1">{fa("envelope", "lg", "solid")} <{member_details["email"]}></div>
+                        {member_email_details}
                         </div>
                         </div>

@Oliver-Leigh

Copy link
Copy Markdown
Contributor Author

Oops - looks like I was a bit too hasty setting up the fork!

@freakboy3742
freakboy3742 self-requested a review July 29, 2026 07:57

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the team - I'll give you the satisfaction of pressing the merge button!

@Oliver-Leigh
Oliver-Leigh merged commit 4476987 into beeware:main Jul 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants