Update the Homebrew tap on every version tag - #98
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The tap job was gated on a tag with no suffix, so a release candidate skipped it. That left the tap update as the one part of the release path a candidate could not prove, which is the opposite of what a candidate is for. The gate is removed.
A candidate now runs the same path the release runs: clone the tap with the token, generate the formula, commit, push.
brew install beetlebugorg/tap/go-dimstherefore serves the newest tag, a candidate included, until the next tag replaces it. The installation page says so, and points atdims versionfor checking which one is installed.What v1.0.0-rc2 already proved
The candidate ran before it was stopped, and the part that had never executed passed:
So
brew install vips, the ANTLR jar wrapper,PKG_CONFIG_PATH,make allon macOS, and the version check all work on real runners for both architectures.Releaseand the tap job were cancelled with the run.The tag and its release are deleted, so
v1.0.0-rc2can be cut again.ghcr.io/beetlebugorg/go-dims:1.0.0-rc2and:nextstill carry that build; the next tag overwrites them.Verify
The workflow parses, and the condition reduces to
startsWith(github.ref_name, 'v'). The job also keepsneeds: [release], so it cannot run unless the release it publishes the formula for succeeded.The formula content, the sha256 values, and the install were checked when the formula landed: generated against the real
v1.0.0-rc1archives, installed from a local tap underhomebrew/brew,dims versionreporting1.0.0-rc1, andbrew testpassing.