Build against upstream govips - #92
Merged
Merged
Conversation
- Remove the replace directive for the fork. - Move govips to v2.18.0. - Name only the upstream project in the license record.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
go.modreplaced govips with a May 2025 fork while therequireline named v2.16.0. Areplaceapplies only to the main module, so anyone importing go-dims as a library built against a different govips than the released binary.The fork is no longer needed. Its changes are in upstream v2.18.0.
replacedirective.github.com/davidbyttow/govips/v2to v2.18.0.LICENSES/govips.MIT, which listed both projects.The fork carried nothing upstream lacks
The fork added 19 exported symbols and tests over upstream v2.16.0, among them
ImageRef.Gravity,ImageRef.Background,ExportMagick, and the BMP and PSD support. Every one of them exists in v2.18.0:ImageRef.Gravityis the one go-dims depends on directly, in the watermark command.Verify
go build ./...andgo build -tags "lambda.norpc lambda" ./...both succeed.go test -race -count=1 ./...passes on the builder image, golden images included, so the byte-exact image comparisons hold across the change.Rendered output was compared directly. Two binaries, one built with the fork and one with upstream, answered the same seven requests:
The watermark case exercises
Gravity, the symbol the fork existed to provide.govulncheckreports no vulnerabilities.