Skip to content
This repository was archived by the owner on Aug 20, 2019. It is now read-only.

Remove duplicated vagrant default config - #410

Merged
thom8 merged 1 commit into
beetboxvm:masterfrom
thom8:vagrant_default
Jun 14, 2017
Merged

thom8 merged 1 commit into
beetboxvm:masterfrom
thom8:vagrant_default

Conversation

@thom8

@thom8 thom8 commented Apr 25, 2017

Copy link
Copy Markdown
Member

Proposed Changes

  • Change

Pull default vars directly from project directory.

@thom8
thom8 force-pushed the vagrant_default branch from 50458f1 to d5e7974 Compare April 25, 2017 11:23
Comment thread Vagrantfile Outdated
project_config = "#{config_dir}/config.yml"
local_config = "#{config_dir}/local.config.yml"
composer_json = "#{beet_root}/composer.json"
vendor_dir = %x(composer config vendor-dir).strip

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thom8

thom8 commented Apr 26, 2017

Copy link
Copy Markdown
Member Author

Linking geerlingguy/drupal-vm#1256

installed_extras_avahi: yes
installed_extras_composer: yes
installed_extras_drush: yes
installed_extras_drupal_console: yes

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thom8 what is the reason to remove console?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's now recommended to add as a project dependency + geerlingguy/drupal-vm#1339 (comment)

@thom8
thom8 force-pushed the vagrant_default branch from 789adec to 6259fa7 Compare June 13, 2017 03:30
@thom8 thom8 closed this Jun 13, 2017
@thom8
thom8 deleted the vagrant_default branch June 13, 2017 03:31
@thom8
thom8 restored the vagrant_default branch June 13, 2017 04:02
@thom8 thom8 reopened this Jun 13, 2017
@thom8
thom8 force-pushed the vagrant_default branch 2 times, most recently from de48abc to 643614e Compare June 13, 2017 04:30
@thom8
thom8 force-pushed the vagrant_default branch from 643614e to 61eda22 Compare June 14, 2017 04:05
@thom8
thom8 merged commit 92faf91 into beetboxvm:master Jun 14, 2017
@thom8
thom8 deleted the vagrant_default branch June 14, 2017 04:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants