Skip to content

Increase test verbosity - #6828

Merged
snejus merged 2 commits into
beetbox:masterfrom
overhacked:overhacked/increase_test_log_level
Jul 13, 2026
Merged

Increase test verbosity#6828
snejus merged 2 commits into
beetbox:masterfrom
overhacked:overhacked/increase_test_log_level

Conversation

@overhacked

Copy link
Copy Markdown
Contributor

Description

Change config["verbose"] from 1 to 2 so that DEBUG-level logging from plugin import tasks and event hooks are emitted. (See beets.plugins._set_log_level_and_params.)

config["verbose"] == 2 does not appear to affect logging anywhere else in the codebase, while config["verbose"] == 3 would enable output of messages logged via BeetsLogger.extra_debug().

To Do

  • Documentation
  • Changelog
  • Tests

Change `config["verbose"]` from `1` to `2` so that DEBUG-level logging
from plugin import tasks and event hooks are emitted.
(See `beets.plugins._set_log_level_and_params`.)

`config["verbose"] == 2` does not appear to affect logging anywhere else
in the codebase, while `config["verbose"] == 3` would enable output of
messages logged via `BeetsLogger.extra_debug()`.

Signed-off-by: Ross Williams <ross@ross-williams.net>
@overhacked
overhacked requested a review from a team as a code owner July 12, 2026 20:27
@github-actions

Copy link
Copy Markdown

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.97%. Comparing base (acc1235) to head (9cc1c04).
⚠️ Report is 3 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6828   +/-   ##
=======================================
  Coverage   74.97%   74.97%           
=======================================
  Files         163      163           
  Lines       21043    21043           
  Branches     3312     3312           
=======================================
  Hits        15777    15777           
  Misses       4514     4514           
  Partials      752      752           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@snejus

snejus commented Jul 13, 2026

Copy link
Copy Markdown
Member

extra_debug is currently primarily used in lastgenre plugin for development - is there any value in enabling this logging level here?

@overhacked

Copy link
Copy Markdown
Contributor Author

extra_debug is currently primarily used in lastgenre plugin for development - is there any value in enabling this logging level here?

I was wondering that myself, if maximum debug logging is the right way to go for tests, and I figured you would have a better sense of that. IMO, if extra_debug() is intended to be a restriction on user-facing console log spam and not "trace-level" logging then we should enable it for tests. If you agree, I'll re-push with verbose=3, or go ahead and amend and merge if you like! Thx!

@snejus

snejus commented Jul 13, 2026

Copy link
Copy Markdown
Member

Thinking about the future, this is actually a good idea - verbosity=2 is what we'd like to have indeed!

@snejus
snejus enabled auto-merge July 13, 2026 12:50
@semohr

semohr commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

extra_debug is currently primarily used in lastgenre plugin for development - is there any value in enabling this logging level here?

I was wondering that myself, if maximum debug logging is the right way to go for tests, and I figured you would have a better sense of that. IMO, if extra_debug() is intended to be a restriction on user-facing console log spam and not "trace-level" logging then we should enable it for tests. If you agree, I'll re-push with verbose=3, or go ahead and amend and merge if you like! Thx!

Im working towards removing this extra debug level at some point 🤣 Feel free to have a look at #6553 and #6773

@snejus
snejus merged commit 9cbbf5b into beetbox:master Jul 13, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants