user can provide timer comment - #806
Open
krugerk wants to merge 7 commits into
Open
Conversation
krugerk
force-pushed
the
feature/627-user-provided-timer-comment
branch
from
June 21, 2026 13:26
8c1473a to
19e9bd0
Compare
preferring lazy var for the comment view where its details can be specified at creation
again lazy var, configuring the view before providing it
again lazy var, configuring the view before providing it
again lazy var, configuring the view before providing it
again lazy var, configuring the view before providing it
again lazy var, configuring the view before providing it
krugerk
force-pushed
the
feature/627-user-provided-timer-comment
branch
from
July 26, 2026 08:19
19e9bd0 to
a1c5179
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Datapoints submitted via timer had a default comment that was not user-edible. This PR provides the interface such that the user may set the comment directly.
For UI changes including screenshots of before and after is great.
Validation
ran app in simulator, used timer interface, submitted datapoints (both edited and not)
Ticket
Implements / Fixes #627