test: start mocked client with no current scan to prevent mock leakage into scan_item#1243
Open
wyzula-jan wants to merge 1 commit into
Open
test: start mocked client with no current scan to prevent mock leakage into scan_item#1243wyzula-jan wants to merge 1 commit into
wyzula-jan wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the shared mocked_client test fixture so a freshly mocked BEC session starts with queue.scan_storage.current_scan = None, preventing MagicMock “current scan” objects from being unintentionally adopted as real scan_items by widgets and later causing noisy async Qt-slot tracebacks during unit tests.
Changes:
- Initialize
bec_dispatcher.client.queue.scan_storage.current_scantoNonein the sharedmocked_clientfixture. - Add an explanatory comment documenting why the fixture sets
current_scantoNone.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There was leak of scan_item in tests, which would look like this in CI (it would pass anyway but should be fixed):