fix(dock_area): fix hiding title window for the first dock #1241
fix(dock_area): fix hiding title window for the first dock #1241wyzula-jan wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a Qt ADS behavior where adding a second dock area can force the first dock area’s title bar to become visible again, overriding this project’s stored “show/hide title bar” preference.
Changes:
- Re-applies stored appearance preferences across all existing docks whenever a new dock is added.
- Re-applies dock preferences after re-attaching floating docks.
- Adds a regression test ensuring the first dock’s “hide title bar” preference survives adding a second dock.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
bec_widgets/widgets/containers/dock_area/basic_dock_area.py |
Re-applies all docks’ stored preferences after dock additions / re-attachments to counter Qt ADS forcing the first title bar visible. |
tests/unit_tests/test_dock_area.py |
Adds a regression test covering the “first dock title bar stays hidden after adding second dock” scenario. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Benchmark comparisonThreshold: 20% (lower is better). No benchmark regression exceeded the configured threshold. No benchmark improvement exceeded the configured threshold. All benchmark results
|
…nd is added, countering the logic of QtADS DockContainerWidgetPrivate::addDockAreasToList code
Description
There is a bespoke logic for showing the title bar in the original QtADS repo which is countering our intended behaviour.
See this method for more info DockContainerWidgetPrivate::addDockAreasToList