Skip to content

fix(dock_area): fix hiding title window for the first dock #1241

Open
wyzula-jan wants to merge 1 commit into
mainfrom
fix/da-title
Open

fix(dock_area): fix hiding title window for the first dock #1241
wyzula-jan wants to merge 1 commit into
mainfrom
fix/da-title

Conversation

@wyzula-jan

Copy link
Copy Markdown
Contributor

Description

There is a bespoke logic for showing the title bar in the original QtADS repo which is countering our intended behaviour.

See this method for more info DockContainerWidgetPrivate::addDockAreasToList

Copilot AI review requested due to automatic review settings July 14, 2026 13:41
@wyzula-jan wyzula-jan self-assigned this Jul 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a Qt ADS behavior where adding a second dock area can force the first dock area’s title bar to become visible again, overriding this project’s stored “show/hide title bar” preference.

Changes:

  • Re-applies stored appearance preferences across all existing docks whenever a new dock is added.
  • Re-applies dock preferences after re-attaching floating docks.
  • Adds a regression test ensuring the first dock’s “hide title bar” preference survives adding a second dock.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
bec_widgets/widgets/containers/dock_area/basic_dock_area.py Re-applies all docks’ stored preferences after dock additions / re-attachments to counter Qt ADS forcing the first title bar visible.
tests/unit_tests/test_dock_area.py Adds a regression test covering the “first dock title bar stays hidden after adding second dock” scenario.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ts/widgets/containers/dock_area/basic_dock_area.py 71.42% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Benchmark comparison

Threshold: 20% (lower is better).
Result: 0 regression(s), 0 improvement(s) beyond threshold.

No benchmark regression exceeded the configured threshold.

No benchmark improvement exceeded the configured threshold.

All benchmark results
Benchmark Baseline Current Change Status
BEC IPython client with companion app 2.20399 s 2.00161 s -9.18% ok
BEC IPython client without companion app 2.18623 s 2.092 s -4.31% ok
Import bec_widgets 0.0131978 s 0.013103 s -0.72% ok
tests/unit_tests/benchmarks/test_dock_area_benchmark.py::test_add_waveform_to_dock_area 0.158608 s 0.152346 s -3.95% ok

@wyzula-jan
wyzula-jan requested a review from wakonig July 14, 2026 14:25
@wyzula-jan
wyzula-jan enabled auto-merge (rebase) July 14, 2026 14:25
…nd is added, countering the logic of QtADS DockContainerWidgetPrivate::addDockAreasToList code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants