Fix orphaned Unity meta files during generated code cleanup - #4771
Merged
Conversation
Contributor
|
Lightbeam link |
gabrielbeamable
approved these changes
Jul 24, 2026
Contributor
Author
|
Since @allister-beamable & @Leinnan are responsible for building the releases, I will wait for one of their reviews before merging. |
This reverts commit 5499371.
Contributor
|
Lightbeam link |
allister-beamable
approved these changes
Jul 27, 2026
allister-beamable
left a comment
Contributor
There was a problem hiding this comment.
Cleaner is better.
allister-beamable
added a commit
that referenced
this pull request
Jul 28, 2026
…build The 6.0.0 build pins CLI 7.2.2, which predates bundles, so download-all-nuget-packages strips BundleTagInfo.cs from Common/Runtime and leaves the committed BundlesService.meta with no asset -- Unity then warns on every asset refresh and cannot clean it, since the package cache is read-only. #4771 fixes the cleanup CLI-side but ships in 7.3.0, which this build does not pin, so remove the files instead. They return automatically once the pin moves to a bundle-containing nuget. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Description
The fix has been implemented after noticing warning existing meta files for empty directories in
ckages/com.beamable/Common/Runtime/BeamCli/Contracts/BundlesServicewhenever a unity project is opened afterV6 RC 7.Removes empty directories and their .meta files after
Beamable.Toolscleans generated Unity source. Directories containing Unity-owned files such as.asmdefremain untouched.Added tests covering the
BundlesService.metaregression and directory preservation.Updated PR builds to install the CLI version pinned by the Unity SDK, preventing generated-code mismatches with the locally built CLI.
Validation
Focused tests pass
CLI solution builds with 0 errors
Checklist
Add those to list or remove the list below altogether:
Notes
When you are merging a feature branch into
main, please squash merge and make sure the final commit contains any relevent JIRA ticket number. If you are merging frommaintostaging, orstagingtoproduction, please use a regular merge commit.Does this introduce tech-debt? If so, have you added an entry to the Tech-debt document?