Skip hidden TitleBar children in visitChildrenForSemantics - #1354
Open
melo936 wants to merge 3 commits into
Open
Skip hidden TitleBar children in visitChildrenForSemantics#1354melo936 wants to merge 3 commits into
melo936 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_TitleSubtitleOverflowBoxhides the title or subtitle when they no longer fit. Hidden children are skipped inperformLayout,paint, and hit testing, but the defaultvisitChildrenForSemanticsstill walks every child. A hidden child that was marked dirty by the size change is never laid out, so the semantics walk hits the assert. Minimizing a maximized window with a screen reader running triggers the_needsLayoutassert.Special thanks to @Stasium for helping.
Pre-launch Checklist
CHANGELOG.mdwith my changes