Fix ComboBox height clipping under text scaling - #1348
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix ComboBox not considering textScaler for height
Fix ComboBox height clipping under text scaling
Aug 2, 2026
bdlukaa
marked this pull request as ready for review
August 2, 2026 23:01
Owner
|
@copilot Use |
Contributor
Author
Updated in 4975aac. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ComboBox used a fixed item height, so larger system text scaling could clip the selected value in the closed control. This updates ComboBox sizing to behave like other input controls by allowing vertical growth with scaled text.
Root cause
heightin_ComboBoxItemContainer, which did not adapt when text metrics increased.Implementation
_ComboBoxItemContainer.Regression coverage
TextScaler.linear(1)vsTextScaler.linear(2)and asserts the scaled case is taller.Changelog
[next]changelog entry documenting ComboBox text-scaling height behavior.