fix: regenerate solr-synonyms-api poetry.lock with cloud-sql-connector 0.2.3#1992
Closed
panish16 wants to merge 2 commits into
Closed
fix: regenerate solr-synonyms-api poetry.lock with cloud-sql-connector 0.2.3#1992panish16 wants to merge 2 commits into
panish16 wants to merge 2 commits into
Conversation
…ctor 0.2.3 Previous lock was stuck at 0.2.0 which predates setup_pg8000_close_event_listener. Regenerated inside python:3.12.2 container using poetry update cloud-sql-connector namex.
panish16
requested review from
davemck513,
mengdong19,
ozamani9gh and
stevenc987
as code owners
Removed in bcgov#1991 as emergency unblock while the lock was stale. Now that poetry.lock is regenerated with cloud-sql-connector 0.2.3, the import resolves correctly and the listener can be added back.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
solr-synonyms-apilock was stuck atcloud-sql-connector 0.2.0which predatessetup_pg8000_close_event_listener(added in 0.2.3). Previous manual lock edits failed because they didn't account for all transitive dependency changes.This lock was properly regenerated inside a
python:3.12.2Docker container using:Verified locally that
cloud_sql_connector.setup_pg8000_close_event_listenerimports correctly with the new lock.Test plan
setup_pg8000_close_event_listenertosynonyms/__init__.py