Skip to content

32956 email update amalg contin#4553

Draft
kialj876 wants to merge 6 commits into
bcgov:mainfrom
kialj876:32956-email-update-amalg-contin
Draft

32956 email update amalg contin#4553
kialj876 wants to merge 6 commits into
bcgov:mainfrom
kialj876:32956-email-update-amalg-contin

Conversation

@kialj876

@kialj876 kialj876 commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Issue #: /bcgov/entity#32956

Description of changes:

  • updated email flows for amalg and continuation in
  • condensed tests with incorp (similar flow and setup)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

kialj876 added 6 commits July 3, 2026 13:10
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
@kialj876 kialj876 marked this pull request as draft July 3, 2026 18:09
@sonarqubecloud

sonarqubecloud Bot commented Jul 3, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
4 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

filing_type, status = email_info["type"], email_info["option"]

regenerate = False
# TODO: need to confirm this case for continuationIn

@kialj876 kialj876 Jul 3, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay so after checking with design it seems I will need to keep some special statuses like this in the old flow - continuationIn has some special review stages before it gets filed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant