Add excludes to cc_action_type_set#669
Open
keith wants to merge 5 commits into
Open
Conversation
keith
requested review from
c-mita,
hvadehra,
pzembrod and
trybka
as code owners
This makes it easier to compose action sets that are very similar to other ones but excluding a few things. This is used today for lto_backend, and in this change is also used for header parsing, which produces a warning when `-c` is passed.
keith
force-pushed
the
ks/add-excludes-to-cc_action_type_set
branch
from
01ff879 to
2e8b05b
Compare
keith
commented
May 26, 2026
| ) | ||
|
|
||
| cc_action_type_set( | ||
| name = "cpp_compile_without_header_parsing", |
Member
Author
There was a problem hiding this comment.
i don't think we had a use for this one so I replaced it with the one that is used and includes more actions
Member
Author
|
@armandomontanez can you to take another look given the discussion on #686 |
| doc = "A list of cc_action_type or cc_action_type_set", | ||
| ), | ||
| "excludes": attr.label_list( | ||
| providers = [ActionTypeSetInfo], |
Collaborator
There was a problem hiding this comment.
I feel like we should start with ActionTypeInfo to prevent weird compositions of cc_action_type_set groups. Does that sound reasonable?
armandomontanez
approved these changes
May 26, 2026
armandomontanez
added
type: feature request
trybka
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier to compose action sets that are very similar to
other ones but excluding a few things. This is used today for
lto_backend, and in this change is also used for header parsing, which
produces a warning when
-cis passed.