Skip to content

chore(pypi): cleanup unused code#3864

Merged
aignas merged 2 commits into
bazel-contrib:mainfrom
aignas:aignas.chore.cleanup_whl_library_targets
Jun 29, 2026
Merged

chore(pypi): cleanup unused code#3864
aignas merged 2 commits into
bazel-contrib:mainfrom
aignas:aignas.chore.cleanup_whl_library_targets

Conversation

@aignas

@aignas aignas commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

This is no longer used starting when we enabled pipstar by default and
did a code cleanup where Python is no longer used to extract the wheels.

Split from #3856

This is no longer used starting when we enabled pipstar by default and
did a code cleanup where Python is no longer used to extract the wheels.
@aignas aignas requested a review from rickeylev as a code owner June 28, 2026 14:59

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the wheel library generation by removing legacy paths, platform-specific dependency handling, and associated tests, focusing instead on whl_library_targets_from_requires. A critical issue was identified where requires_dist, now a keyword-only parameter, is omitted from the serialized kwargs in the generated BUILD.bazel file, which would break dependency resolution. A suggestion was provided to explicitly add requires_dist back to kwargs when it is not empty.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread python/private/pypi/generate_whl_library_build_bazel.bzl
@aignas aignas added this pull request to the merge queue Jun 28, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 28, 2026
@aignas aignas added this pull request to the merge queue Jun 29, 2026
Merged via the queue into bazel-contrib:main with commit 367190a Jun 29, 2026
6 checks passed
@aignas aignas deleted the aignas.chore.cleanup_whl_library_targets branch June 29, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants