Cache article thumbnails#1680
Merged
Merged
Conversation
This should hopefully reduce the pop in of the article thumbnails, important if we want the option to show the curated page by default. I don't think it makes much sense to do it for the article images itself, as revisits are probably rare, and so would only take unneeded space on disk.
Collaborator
|
wait the nitpick wasn't relevant to this pr, mb |
Collaborator
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should hopefully reduce the pop in of the article thumbnails, important if we want the option to show the curated page by default.
I don't think it makes much sense to do it for the article images itself, as revisits are probably rare, and so would only take unneeded space on disk.