Add ADDRESS_HOME_ZIP_AND_CITY field to FR model#88
Open
aatalyk wants to merge 1 commit into
Open
Conversation
aatalyk
force-pushed
the
fix-add-zip-and-city-france
branch
from
January 30, 2026 12:21
6538238 to
4bb4379
Compare
skyman503
reviewed
Jan 30, 2026
aatalyk
force-pushed
the
fix-add-zip-and-city-france
branch
from
January 30, 2026 13:21
4bb4379 to
f5fa8bf
Compare
aatalyk
force-pushed
the
fix-add-zip-and-city-france
branch
from
February 2, 2026 08:24
f5fa8bf to
39e1f1b
Compare
Collaborator
|
LGTM % Norge's review and adding the PR description |
skyman503
approved these changes
Feb 2, 2026
Author
The description is added, thanks! |
m-maryia
reviewed
Feb 2, 2026
m-maryia
reviewed
Feb 2, 2026
aatalyk
force-pushed
the
fix-add-zip-and-city-france
branch
from
February 2, 2026 11:45
39e1f1b to
27c29dc
Compare
Author
|
Done, thanks! |
aatalyk
force-pushed
the
fix-add-zip-and-city-france
branch
from
February 4, 2026 12:57
27c29dc to
58ad533
Compare
m-maryia
reviewed
Feb 4, 2026
aatalyk
force-pushed
the
fix-add-zip-and-city-france
branch
from
February 5, 2026 08:05
58ad533 to
a2d8f40
Compare
m-maryia
approved these changes
Feb 5, 2026
aatalyk
force-pushed
the
fix-add-zip-and-city-france
branch
from
February 5, 2026 09:51
a2d8f40 to
7ae6ee9
Compare
oroko123
reviewed
Feb 5, 2026
|
|
||
| extra-definitions: | ||
| address: | ||
| - street-address |
Collaborator
There was a problem hiding this comment.
drive by:
What's the reasoning for having both street-address and street-address-alternative-1 as children of address and then skipping 'street-address' in formatting rules?
Could we just not add street-address at all instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR introduces a new field type ADDRESS_HOME_ZIP_AND_CITY to the French address model. The new field type will handle fields where a postal code and a city are written in the single field (eg. "75000 Paris").