Allow independent configuration of AcquisitionFrameRate for hardware triggering - #147
Open
michaelarusso wants to merge 1 commit into
Open
Allow independent configuration of AcquisitionFrameRate for hardware triggering#147michaelarusso wants to merge 1 commit into
michaelarusso wants to merge 1 commit into
Conversation
thiesmoeller
added a commit
that referenced
this pull request
Jul 8, 2026
Merge architecture_refactor and Conan-based CI from update_build, require pylon C++ SDK 12.2+, and bump the project to 2.0.0. - Apply PR #147/#148 locally: hardware-trigger framerate and Jetson NVMM paths - Fix OffsetY caps on cameras without ROI, direct open by serial (#138/#140) - Relax PFS nodemap sanity check (#136/#141) - Stabilize compat tests to compare static pylonsrc properties only - Run state tests with PYLON_CAMEMU=1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow independent configuration of AcquisitionFrameRate for hardware triggering
Problem:
When a camera operates with
TriggerMode=On(using an external hardware trigger), forcing the camera'sAcquisitionFrameRateto exactly match the negotiated GStreamer pipeline framerate capability causes frame drops and rate inconsistencies. This occurs because the clock of the external hardware trigger drifts relative to the Basler camera's internal clock, resulting in missed triggers when the strict timing window is violated.Context:
In GenICam/Pylon,
AcquisitionFrameRateis documented to act as an upper limit (throttling boundary) to prevent over-triggering, rather than a strict interval setting, especially when using external triggers. However, the plugin previously blacklisted these properties and unconditionally forced the camera's framerate to strictly mirror the GStreamer capability negotiated during caps resolution.Solution:
AcquisitionFrameRateEnable,AcquisitionFrameRate, andAcquisitionFrameRateAbshave been removed from thepropfilter_setingstpylonfeaturewalker.cpp. This allows users to correctly expose and configure these parameters directly via GStreamer element properties (e.g.,cam::AcquisitionFrameRateEnable=True) or via PFS.gst_pylon_set_configuration()to check ifAcquisitionFrameRateEnablewas previously enabled (either via a PFS config or element properties). If enabled, the plugin honors the pre-configured limit and skips overwriting it with the pipeline's arbitrary caps framerate.