Reattach punctuation split off by the hyphenation pass#429
Open
neoden wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #428.
hyphenate_paragraphrecords one merge range per alphabetic run, socleanup_paragraphonly glues the syllables back together and the punctuation boxes it split off stay detached, corrupting every consumer of the page's text boxes (highlight/annotation text, search/define on a selection).Record a single merge range spanning the whole token instead.
cleanup_paragraphthen reassembles the token exactly as it was before hyphenation — including tokens that gained no hyphenation points but were still split (e.g.can't,well-known,(word)).Line breaking is unaffected: the boxes and penalties fed to
total_fitare unchanged, and a full-book layout comparison (1200+ pages) shows identical page counts and line breaks, with only the text-box granularity restored.