fix #4284 【プラグイン】カスタムコンテンツ:テーブル管理のテーブル登録・編集で識別名に半角大文字が使えない件のヘルプを修正#4394
Open
kaburk wants to merge 1 commit into
Open
fix #4284 【プラグイン】カスタムコンテンツ:テーブル管理のテーブル登録・編集で識別名に半角大文字が使えない件のヘルプを修正#4394kaburk wants to merge 1 commit into
kaburk wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
カスタムコンテンツの「カスタムテーブル」登録・編集画面において、識別名（name）に半角大文字が使えない実態に合わせて、ヘルプ文言と翻訳カタログを更新するPRです。
Changes:
- 管理画面（CustomTables フォーム）の識別名ヘルプを「小文字制約」へ修正
baser_core.potの msgid を更新し、抽出元文言を同期- 英語翻訳（
en/baser_core.po）に新 msgid と訳文を追加・更新
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| plugins/bc-admin-third/templates/plugin/BcCustomContent/Admin/element/CustomTables/form.php | 識別名入力欄のヘルプ文言を小文字制約に合わせて修正 |
| plugins/baser-core/resources/locales/en/baser_core.po | 変更後ヘルプ文言の英訳を追加し、旧エントリを整理 |
| plugins/baser-core/resources/locales/baser_core.pot | 変更後ヘルプ文言をテンプレートへ反映 |
Comments suppressed due to low confidence (1)
plugins/bc-admin-third/templates/plugin/BcCustomContent/Admin/element/CustomTables/form.php:87
- 同一プラグイン内の類似フォーム（例:
CustomFields/form.php）では「半角小文字英数字とアンダースコア（ _ ）のみ利用可能です。」という既存文言が使われています。本箇所だけ「半角英数小文字…」という別 msgid を新規追加すると翻訳エントリが重複し、UI 文言の一貫性も下がるため、既存文言への寄せ（または既存表現に合わせた統一）を検討してください。
<?php echo __d('baser_core', '半角英数小文字とアンダースコアのみ利用できます。') ?>
| <?php echo __d('baser_core', '半角英数字とアンダースコアのみ利用できます。') ?> | ||
| <?php echo __d('baser_core', '半角英数小文字とアンダースコアのみ利用できます。') ?> | ||
| </div> | ||
| <?php echo $this->BcAdminForm->error('name') ?> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
よろしくお願いします。