fix #4337 【システム】 コンテンツコピー時に layout_template が引き継がれない件を修正#4392
Open
kaburk wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
本PRは、コンテンツのコピー処理において layout_template が引き継がれない不具合（#4337）を、コピー時に参照するプロパティ名のタイポ修正によって解消するものです。layout_tmplate（誤）参照のため常に未設定扱いになっていた箇所を、layout_template（正）参照に統一しています。
Changes:
ContentLinksTable::copy()のlayout_template参照タイポを修正PagesTable::copy()のlayout_template参照タイポを修正ContentFoldersTable::copy()のlayout_template参照タイポを修正
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| plugins/bc-content-link/src/Model/Table/ContentLinksTable.php | コピー時に layout_template を正しいプロパティから引き継ぐよう修正 |
| plugins/baser-core/src/Model/Table/PagesTable.php | ページコピー時の layout_template 引き継ぎ不具合をタイポ修正で解消 |
| plugins/baser-core/src/Model/Table/ContentFoldersTable.php | コンテンツフォルダコピー時の layout_template 引き継ぎ不具合をタイポ修正で解消 |
Comment on lines
108
to
113
| 'author_id' => $newAuthorId, | ||
| 'site_id' => $newSiteId, | ||
| 'description' => $entity->content->description, | ||
| 'eyecatch' => $entity->content->eyecatch, | ||
| 'layout_template' => $entity->content->layout_tmplate ?? '', | ||
| 'layout_template' => $entity->content->layout_template ?? '', | ||
| 'url' => $entity->content->url |
Comment on lines
276
to
281
| 'parent_id' => $newParentId, | ||
| 'title' => $newTitle ?? $oldPage->content->title . '_copy', | ||
| 'author_id' => $newAuthorId, | ||
| 'site_id' => $newSiteId, | ||
| 'layout_template' => $page->content->layout_tmplate ?? '' | ||
| 'layout_template' => $page->content->layout_template ?? '' | ||
| ]); |
Comment on lines
175
to
180
| 'author_id' => $newAuthorId, | ||
| 'site_id' => $newSiteId, | ||
| 'description' => $entity->content->description, | ||
| 'eyecatch' => $entity->content->eyecatch, | ||
| 'layout_template' => $entity->content->layout_tmplate ?? '' | ||
| 'layout_template' => $entity->content->layout_template ?? '' | ||
| ]); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
よろしくお願いします。