fix #4338 【メール】確認画面で送信時にバリデーションエラーが発生するとエラーになる件を修正#4391
Open
kaburk wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
本PRは、メールフォームの確認画面から送信した際に、バリデーションエラー（PersistenceFailedException）が発生すると致命的エラーになる不具合（#4338）を修正するものです。例外捕捉時に誤った変数へアクセスしていた箇所を、例外から取得したエンティティに対する操作へ修正しています。
Changes:
PersistenceFailedException発生時に未定義になり得る$mailMessageではなく、例外エンティティ$entityのauth_captchaをクリアするよう修正
Comment on lines
282
to
286
| } catch (PersistenceFailedException $e) { | ||
| $entity = $e->getEntity(); | ||
| $mailMessage->auth_captcha = ''; | ||
| $entity->auth_captcha = ''; | ||
| $this->BcMessage->setError(__d('baser_core', '入力内容を確認し、再度送信してください。')); | ||
| $this->set($service->getViewVarsForConfirm($mailContent, $entity)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
よろしくお願いします。