fix #4355 【プラグイン】BcSeoHelperEventListener のネストループで break が内側しか抜けていない問題を解消#4390
Open
kaburk wants to merge 1 commit into
Open
fix #4355 【プラグイン】BcSeoHelperEventListener のネストループで break が内側しか抜けていない問題を解消#4390kaburk wants to merge 1 commit into
kaburk wants to merge 1 commit into
Conversation
…が内側しか抜けていない問題を解消
Contributor
There was a problem hiding this comment.
Pull request overview
BcSeoHelperEventListener の bcFormTableAfter() 内で、seoForms 設定から対象の $type を探索するネストした foreach ループにおいて、該当イベントIDが見つかった際に外側ループまで抜けられず探索が継続してしまう問題（#4355）を解消するPRです。
Changes:
- ネストループ内の
break;をbreak 2;に変更し、イベントID一致時に外側ループまで確実に脱出するよう修正
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
よろしくお願いします。