-
Notifications
You must be signed in to change notification settings - Fork 141
fix #4364 【プラグイン】カスタムコンテンツのAI用の仕様書の更新 #4388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kaburk
wants to merge
1
commit into
baserproject:5.2.x
Choose a base branch
from
kaburk:5.2.x-#4364
base: 5.2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+18
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,10 +53,26 @@ echo $this->BcBaser->getCustomFieldValue($customEntry, 'field_name'); | |
| ``` | ||
|
|
||
| ## textarea の表示について | ||
| 内部的に nl2br() が適用されているので、改行はそのまま表示されます。 | ||
| デフォルトでは内部的に `nl2br(h())` が適用されるため、改行はそのまま表示され、HTMLタグはエスケープされます。 | ||
|
|
||
| `escape => false` を指定するとエスケープと `nl2br()` が無効になり、フィールド値をそのまま出力できます。 | ||
| span タグなどの HTML を含む場合に利用しますが、出力値の信頼性を確認した上で使用してください。 | ||
|
|
||
| ```php | ||
| echo $this->BcBaser->getCustomFieldValue($customEntry, 'field_name', ['escape' => false]); | ||
| ``` | ||
|
|
||
| `escape => false` にすると `nl2br()` も無効になるため、改行を `<br>` に変換したい場合は呼び出し側で `nl2br()` を適用してください。 | ||
|
|
||
| ```php | ||
| echo nl2br($this->BcBaser->getCustomFieldValue($customEntry, 'field_name', ['escape' => false])); | ||
| ``` | ||
|
|
||
| ## CSSの作成 | ||
| - 既存のテーマにテンプレートを追加作成する場合、CSSの作成時、Aタグの文字色は親設定を引き継いでいる可能性があるので、important を付けておく。 | ||
|
|
||
| ## その他 | ||
| - テキストエリアは h() でエスケープすると改行が<br> として表示されてしまうので使わない。 | ||
| - テキスト・テキストエリアフィールドはデフォルトで `h()` によるエスケープが有効です。 | ||
| - `escape => false` を指定すると `h()` によるエスケープを無効化できます(テキスト・テキストエリア両フィールド対応)。これにより span タグなどの HTML をそのまま出力できます。 | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ここはこのままでOKです。 |
||
| - テキストエリアで `escape => false` を指定した場合、`nl2br()` も同時に無効になります。 | ||
| - `escape => false` を使用する際は、出力する値が信頼済みの入力に限定されていることを確認してください(XSS に注意)。 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここはこのままでOKです。