Skip to content

ci: harden base-demo validation workflow #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codeforester merged 1 commit into from
Aug 27, 2026
Merged

ci: harden base-demo validation workflow #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,13 @@ concurrency:
group: validate-demo-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

permissions:
contents: read

jobs:
validate:
runs-on: macos-latest
timeout-minutes: 35
env:
BASE_CACHE_DIR: ${{ github.workspace }}/.base-cache
BASE_BASH_LIBS_DIR: ${{ github.workspace }}/.dependencies/base-bash-libs/lib/bash
Expand Down Expand Up @@ -194,6 +198,7 @@ jobs:

validate-base-cli-source:
runs-on: macos-latest
timeout-minutes: 25
env:
BASE_CACHE_DIR: ${{ github.workspace }}/.base-cache
BASE_BASH_LIBS_DIR: ${{ github.workspace }}/.dependencies/base-bash-libs/lib/bash
Expand Down Expand Up @@ -254,6 +259,7 @@ jobs:

validate-ubuntu:
runs-on: ubuntu-latest
timeout-minutes: 35
env:
BASE_CACHE_DIR: ${{ github.workspace }}/.base-cache
BASE_BASH_LIBS_DIR: ${{ github.workspace }}/.dependencies/base-bash-libs/lib/bash
Expand Down
17 changes: 17 additions & 0 deletions tests/validate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ if [[ -n "$floating_actions_refs" ]]; then
fi

python3 - <<'PY'
import re
from pathlib import Path

workflow = Path(".github/workflows/tests.yml").read_text()
Expand All @@ -243,6 +244,22 @@ for job_id in ("validate", "validate-base-cli-source", "validate-ubuntu"):
".github/workflows/tests.yml must preserve exactly one stable "
f"{job_id} job declaration."
)

if "permissions:\n contents: read" not in workflow:
raise SystemExit(
".github/workflows/tests.yml must declare a read-only contents permission default."
)

for job_id in ("validate", "validate-base-cli-source", "validate-ubuntu"):
match = re.search(
rf"(?ms)^ {re.escape(job_id)}:\n(.*?)(?=^ [A-Za-z0-9_-]+:|\Z)",
workflow,
)
if match is None or re.search(r"(?m)^ timeout-minutes:\s*[1-9][0-9]*\s*$", match.group(1)) is None:
raise SystemExit(
".github/workflows/tests.yml must give every validation job an explicit positive timeout: "
f"{job_id}."
)
PY

grep -Fq 'pull_request_target:' .github/workflows/issue-branch-policy.yml || {
Expand Down
Loading