Skip to content

Fix JSON-mode retention precedence - #219

Merged
codeforester merged 5 commits into
mainfrom
bug/177-20260819-dead-json-only-retention-branch-in-create-context-can-never
Aug 19, 2026
Merged

Fix JSON-mode retention precedence#219
codeforester merged 5 commits into
mainfrom
bug/177-20260819-dead-json-only-retention-branch-in-create-context-can-never

Conversation

@codeforester

Copy link
Copy Markdown
Contributor

Summary

  • Make implicit JSON-mode retention use the documented count-only 20-bundle default.
  • Preserve explicit retention/run-bound policies, human-mode safe defaults, and the max_log_files compatibility path.
  • Add regression coverage, design/implementation documentation, and a changelog entry.

Validation

  • UV_CACHE_DIR=/private/tmp/base-cli-uv-cache uv run --extra dev --extra typer pytest -q
  • UV_CACHE_DIR=/private/tmp/base-cli-uv-cache uv run --extra quality ruff format --check lib/python/base_cli/_app_core.py tests/test_json_contracts.py
  • UV_CACHE_DIR=/private/tmp/base-cli-uv-cache uv run --extra quality ruff check lib/python/base_cli/_app_core.py tests/test_json_contracts.py
  • UV_CACHE_DIR=/private/tmp/base-cli-uv-cache uv run --extra quality mypy --no-incremental --strict lib/python/base_cli
  • ./tests/validate.sh
  • git diff --check

Closes #177.

@codeforester
codeforester force-pushed the bug/177-20260819-dead-json-only-retention-branch-in-create-context-can-never branch from 89ab5b5 to 2a3f307 Compare August 19, 2026 12:11
@codeforester
codeforester merged commit 263d893 into main Aug 19, 2026
128 of 130 checks passed
@codeforester
codeforester deleted the bug/177-20260819-dead-json-only-retention-branch-in-create-context-can-never branch August 19, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dead JSON-only retention branch in _create_context() can never execute

1 participant