Skip to content

Fix pre-parse JSON flag detection (#212) - #217

Merged
codeforester merged 1 commit into
mainfrom
bug/212-20260818-json-requested-misdetects-combined-json-no-json-declarations
Aug 18, 2026
Merged

Fix pre-parse JSON flag detection (#212)#217
codeforester merged 1 commit into
mainfrom
bug/212-20260818-json-requested-misdetects-combined-json-no-json-declarations

Conversation

@codeforester

Copy link
Copy Markdown
Contributor

Summary

  • Parse combined positive/negative JSON lifecycle declarations consistently with the rest of the lifecycle flags.
  • Let the last explicit JSON flag override the configured default before pre-parse errors are rendered.
  • Add regression coverage for combined declarations and explicit --no-json with a true default.

Validation

  • uv run --extra dev --extra typer --extra quality pytest tests/test_json_contracts.py -q
  • uv run --extra quality ruff format --check lib/python/base_cli/app.py tests/test_json_contracts.py
  • uv run --extra quality ruff check lib/python/base_cli/app.py tests/test_json_contracts.py
  • uv run --extra quality mypy lib/python/base_cli/app.py

Closes #212.

@codeforester
codeforester merged commit 44cd767 into main Aug 18, 2026
90 checks passed
@codeforester
codeforester deleted the bug/212-20260818-json-requested-misdetects-combined-json-no-json-declarations branch August 18, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

_json_requested() misdetects combined --json/--no-json declarations and ignores explicit negation

1 participant