Repository navigation
basert: with no --version, install the newest baseRT release this build drives
#31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 17 additions & 1 deletion
18
crates/superfluid-adapters/superfluid-adapter-basert/recipe.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codex Review — [P2] Bound the listing lookup before putting it ahead of the pins
Every unversioned install (including a fresh
serve) now waits here before using a pinned release.fetch_json()in adapter-kit invokes curl without a connect timeout, overall timeout, or low-speed deadline, so a connection that succeeds but stops sending the listing can block forever; theErrbranch that is supposed to provide the pinned fallback is never reached. I reproduced this using a local TLS fixture that sends HTTP 200 and then stalls its JSON body: the old planner returned its pin in ~0.38s, while the new one remained blocked until I terminated it after 8s. This affects users whose API connection stalls even when release assets are reachable. Give release discovery a bounded deadline and fall back to the pins on expiry before making it unconditional.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accepted, fixed in e22a3ac. The fix is in the kit, since
fetch_jsonis also what llama.cpp's release lookup and the speculator catalog call, and neither should block forever either. Every lookup now ends within 20 s, retries included (--connect-timeout,--max-time,--retry-max-time), andfetch_json_within(url, deadline)takes another deadline. When the listing times out,planfalls back to the pins as designed.Failing first:
a_json_lookup_that_stalls_gives_up_by_its_deadlinepoints a lookup with a 2 s deadline at a socket that accepts and never answers. Without the flags it gave no answer within the test's 15 s; with them it returns an error in about 2 s. I also checked your case, HTTP 200 headers followed by a body that never comes, directly with curl and the same flags: it exits 28 at the deadline, with no retry past it.