Repository navigation
feat(scaling): bench run and load test detail pages - #203
Merged
Merged
Conversation
Co-authored-by: Toshi <toshi-noreply@coinbase.com>
Co-authored-by: Toshi <toshi-noreply@coinbase.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0x00101010
added this pull request to stack #202
October 16, 2026 14:09
Collaborator
✅ Heimdall Review Status
|
mw2000
approved these changes
Oct 16, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
A base-bench run is split across two old pages (
/benchmark/run/<id>and/benchmark/run-comparison/<id>, a wall of ungrouped charts), and a load test leads with a workload-specific swaps/s number. These pages put each run on one page in the scaling style, with Mgas/s as the unit.What
/scaling/runs/bench/<id>: one row per configuration of the benchmark run (an id can cover several), thresholds as a table (metric, value, warning, error, status), per-block charts grouped Build / State root / Persist / Sparse trie / Validate with only Build open and sequencer and validator as two series, raw config, JSON/CSV downloads. Every metric inmetricDefinitions.tsis assigned to one group (tested)./scaling/runs/load/<network>/<timestamp>: observed Mgas/s headline with≈ N tx/s at this mix(gas/s ÷ gas per confirmed tx), target / duration / senders / in-flight inline with the full config behind an info icon, throughput chart, block and Flashblocks latency percentile bars, gas stats, failure reasons, previous/next run.app/scaling/runs/components/(no new dependency); nothing imported fromapp/benchmark/componentsorviews.downloadUtils.tsmoves toapp/scaling/runs/lib/unchanged.sequencer/latency/get_payload, how report-api writes them) now count toward run status; before, they were skipped, so a breached threshold still readsuccess.Notes
scalingsurface; the public build returns 404 for both routes.Screenshots
Internal dev build with report-api responses replaced by the committed synthetic fixture (invented numbers).
/scaling/runs/bench/test-synthetic-1at 1280 px and 360 px:/scaling/runs/load/sepolia/<timestamp>at 1280 px and 360 px, and a run that stopped with a fatal error:Test plan
npm test,npm run typecheck,npm run lint,npm run build,npm run build:internal,npm run llms -- --check,npm run agents -- --checkBenchRun.test.tsx: configurations, thresholds (role-prefixed one marks its configerror), stage order with only Build open, alias-resolved metric, metrics fetch error, every metric in one stage.LoadRun.test.tsx: headline, translation, knobs, chart, latency bars, previous/next, fatal run.dev:internalat 360 px and 1280 px; public build returns 404 for both routes.