Repository navigation
refactor(tests): collapse repeated buildAndValidateSignature setup - #217
Merged
jackchuma merged 1 commit intoOct 28, 2026
Merged
Conversation
J-Engine-Session: toshi:6d9fdb9a-c736-4278-8ea8-de2f491a1a2a
Collaborator
Author
Review round 1Reviewers: cbhq-openai/gpt-6.1-sol 🤖 Reply generated with Toshi |
jackchuma
marked this pull request as ready for review
October 28, 2026 13:00
0xth4nh
reviewed
Oct 28, 2026
0xth4nh
left a comment
Contributor
There was a problem hiding this comment.
Looks Good to Thanh's Toshi
xenoliss
approved these changes
Oct 28, 2026
Collaborator
✅ Heimdall Review Status
|
jackchuma
deleted the
jackchuma/chain-6345-task-signing-tool-collapse-repeated
branch
October 28, 2026 13:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
In
__tests__/task-origin-validate.test.ts, the tenbuildAndValidateSignaturetests each repeated the same 8–10 line options literal, differing in only 1–3 fields, and each castrolewith a redundantas TaskOriginRole.validate(overrides: Partial<TaskOriginVerifyOptions>)helper with defaultsVALID_TASK_FOLDER,creator-signature.json,TASK_CREATOR_EMAIL, and'taskCreator'.as TaskOriginRolecasts and theTaskOriginRoleimport.TaskOriginVerifyOptions.roleis already typedTaskOriginRole, so the literals get contextual typing.Test-only. No production code changes.
Notes to reviewers
createDeterministicTarballtests, fixtures, and the cache/out comment near the top of the file are untouched.How has it been tested?
npx jest __tests__/task-origin-validate.test.ts: 14/14 before and after.npm test: 172/172.npm run lint,npx tsc --noEmit,npm run format:check: pass.grep -c "as TaskOriginRole" __tests__/task-origin-validate.test.ts: 0.No new tests: behavior-preserving refactor of existing tests.