Repository navigation
test(deployments): table-drive normalizeUrl and share task fixture helper - #212
Merged
Merged
Conversation
…lper Co-authored-by: Toshi <toshi-noreply@coinbase.com> J-Engine-Session: toshi:b5ec6472-b003-4cd2-9285-e8921a340f34
Collaborator
✅ Heimdall Review Status
|
jackchuma
marked this pull request as ready for review
October 26, 2026 16:17
0xth4nh
reviewed
Oct 26, 2026
0xth4nh
left a comment
Contributor
There was a problem hiding this comment.
Looks Good to Thanh's Toshi
mw2000
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test-only cleanup of
src/lib/__tests__/deployments.test.ts.deployments.tsis unchanged.normalizeUrl: the 17 single-assertion tests become twoit.eachtables, one for accepted inputs (input → expected output) and one for rejected inputs (→undefined). Every input string and expected value is kept, including all three trailing-punctuation cases.getUpgradeOptions: a localmakeTask(id, network, readme?)helper creates<tempDir>/active/evm/tasks/<id>/config/<network>/validations, writes the README when given, and enters the tool directory. The five active-task tests use it. The legacy root-level layout test keeps its own setup so it still builds a legacy layout and no active task.getUpgradeOptionscall, and assertion is unchanged, including pending status, the serializedexecutionLinkscheck, descending task order, and the non-date-prefix filter.Interfaces removed
None. Only the test file changes.
Validation
npm test: 14 suites, 172 tests pass.normalizeUrlnow reports 19 cases because the old three-assertion punctuation test became three table rows; no case was added or dropped.npm run lint,npx tsc --noEmit,npm run build,npx prettier --check src/lib/__tests__/deployments.test.tspass.No new tests: this change only restructures existing ones.
Why this cleanup
path.joinblocks, or 17 near-identicalnormalizeUrltest bodies. Each discovery test is now one to three setup lines plus its unchanged assertions.