Skip to content

feat(base-mcp): add quote display sanity checks reference#72

Open
mehmetkr-31 wants to merge 1 commit into
base:masterfrom
mehmetkr-31:feat/quote-display-sanity-checks
Open

feat(base-mcp): add quote display sanity checks reference#72
mehmetkr-31 wants to merge 1 commit into
base:masterfrom
mehmetkr-31:feat/quote-display-sanity-checks

Conversation

@mehmetkr-31

Copy link
Copy Markdown

This PR resolves issue #68 by adding a reference guide under skills/base-mcp/references/quote-sanity.md. It instructs agents to validate raw token amounts against decimals before displaying a quote or requesting transaction approvals to avoid formatting errors.

@cb-heimdall

Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants