Repository navigation
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
🟡 Heimdall Review Status
|
…-8430-everest-transactions-vs-eip
Docs reviewRisk: High (one human reviewer (the tab owner), with an AI pre-review) ·
Verdict: Fits, with changes · reviewed The change adds a short section to the live Base Transactions spec page explaining how EIP-8430 relates to EIP-8130. The page is the right home, and the facts match the PR's cited sources. The section is mostly well placed, but it sits above the Transaction Format and reads as explanation rather than normative spec. The last paragraph also mixes several ideas, and the page now links EIP-8430 and EIP-8130 inconsistently. Suggestions
What the reviewer checked
Advisory review from the Docs PR review workflow (run). It does not approve, block, or edit this PR. Add the |
| - **EIP-8430** defines the transaction type (`0x79`) described on this page. | ||
| - **EIP-8130** now specifies Keystore Accounts, an onchain keystore that authorizes account actors through authenticator contracts. It also describes how the Keystore can integrate with the EIP-8430 transaction type. | ||
|
|
||
| Earlier drafts of EIP-8130 defined the `0x79` transaction type themselves, so older material may call these "EIP-8130 transactions." EIP-8430 is an open proposal in the Ethereum EIPs repository, and EIP-8130 has Draft status. A proposal's EIP status does not tell you whether Base Transactions are live on Base. Activation follows the Everest network upgrade. |
There was a problem hiding this comment.
Split the overloaded closing paragraph
The paragraph covers legacy naming, EIP status, and activation in one block, and ends with an extra activation sentence that repeats the Warning above. Split it into two ideas and drop the duplicate activation line. Keep one sentence per idea, in active voice.
| Earlier drafts of EIP-8130 defined the `0x79` transaction type themselves, so older material may call these "EIP-8130 transactions." EIP-8430 is an open proposal in the Ethereum EIPs repository, and EIP-8130 has Draft status. A proposal's EIP status does not tell you whether Base Transactions are live on Base. Activation follows the Everest network upgrade. | |
| Earlier drafts of EIP-8130 defined the `0x79` transaction type, so older material may call these "EIP-8130 transactions." | |
| EIP-8430 is an open proposal in the Ethereum EIPs repository, and EIP-8130 has Draft status. A proposal's status does not tell you whether Base Transactions are live on Base. |
| EIP-8430 is not a rename of [EIP-8130](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-8130.md). It is a separate proposal that splits the transaction type out of EIP-8130, with no dependency on a keystore. | ||
|
|
||
| - **EIP-8430** defines the transaction type (`0x79`) described on this page. | ||
| - **EIP-8130** now specifies Keystore Accounts, an onchain keystore that authorizes account actors through authenticator contracts. It also describes how the Keystore can integrate with the EIP-8430 transaction type. |
There was a problem hiding this comment.
Tighten the EIP-8130 bullet and define terms
The bullet is long and introduces "authenticator contracts" and "Keystore" without defining them. It also capitalizes "Keystore" inconsistently with "keystore" in line 24. Shorten it and use one form of the term.
| - **EIP-8130** now specifies Keystore Accounts, an onchain keystore that authorizes account actors through authenticator contracts. It also describes how the Keystore can integrate with the EIP-8430 transaction type. | |
| - **EIP-8130** now specifies Keystore Accounts, an onchain keystore that authorizes account actors through authenticator contracts. It also describes how a keystore integrates with the EIP-8430 transaction type. |
What changed? Why?
Adds a short "Relationship to EIP-8130" section to
docs/specifications/base-transactions.mdx. It explains that EIP-8430 is a separate transaction-type proposal split out of EIP-8130, not a rename. EIP-8130 now specifies Keystore Accounts and describes an integration with the EIP-8430 transaction type. The section also notes that earlier EIP-8130 drafts defined type0x79, which is why older material calls these "EIP-8130 transactions". It states that EIP status does not tell you whether Base Transactions are live on Base.This closes Base Knowledge Base gap
gap-20261013-eip-8430-everest-transactions-vs-eip: "How does EIP-8430 (Base Transactions, Everest) relate to EIP-8130 (native account abstraction on vibenet)? Is 8430 a successor/rename of 8130 or a separate transaction type?" In an agent evaluation, web-search agents answered "EIP-8130" when asked which EIP defines Base Transactions in Everest.Notes to reviewers
Primary sources for each fact:
0x79; EIP-8130 specifies an integration: Add EIP: AA Transaction Type ethereum/EIPs#12385 (open), PR description andEIPS/eip-8430.md.AA_TX_TYPE = 0x79:EIPS/eip-8130.mdat ethereum/EIPs commit16390e1f, before the split commit1a1f470f.SME confirmation is not required. The section does not claim that either EIP has been accepted, or give an Everest activation date or Mainnet availability.
Out of scope, flagged for follow-up:
docs/build-on-base/run-a-local-devnet.mdxstill says "EIP-8130 transactions", matching the base/base devnet README. The new section explains that legacy name.node scripts/validate-docs-structure.jsalready fails on master because of the/upgrades/denim/eip-8130redirect chain to the missing/specifications/native-account-abstraction. This PR doesn't touchdocs.json.How has it been tested?
node scripts/lint-mdx.js --files-from=<changed files>: 0 errors. There are 2 warnings, both on an existing code block.node scripts/validate-docs-structure.js: the same 2 redirect errors appear with and without this change, so they come from master.https://github.com/ethereum/EIPs/blob/master/EIPS/eip-8130.mdreturns HTTP 200.Screenshots
N/A (text-only change)
Generated with Toshi