fix: correct broken redirect destinations for basenames wagmi guide and apps quickstart - #1784
Open
teyrebaz33 wants to merge 1 commit into
Open
fix: correct broken redirect destinations for basenames wagmi guide and apps quickstart#1784teyrebaz33 wants to merge 1 commit into
teyrebaz33 wants to merge 1 commit into
Conversation
…nd apps quickstart Two redirect destination groups in docs.json pointed to pages that no longer exist: - 39 redirects (mostly legacy /onchainkit/identity/* paths) pointed to /base-account/basenames/basenames-wagmi-tutorial, which does not exist. The actual wagmi + basenames guide lives at /base-account/framework-integrations/wagmi/basenames. - 36 redirects (legacy /mini-apps/* and onchainkit minikit paths) pointed to /apps/quickstart/create-new-app, which does not exist. The current quickstart page for creating a new app is /apps/quickstart/build-app. Both destinations were verified against docs.json navigation and the actual docs/ file tree.
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #1783
Problem
Two groups of redirects in
docs.jsonpointed to pages that no longer exist:/base-account/basenames/basenames-wagmi-tutorial(doesn't exist)/apps/quickstart/create-new-app(doesn't exist)Fix
/base-account/framework-integrations/wagmi/basenames, the actual wagmi + basenames guide (verified by content match: title, description, and body all reference wagmi/viem basenames setup)./apps/quickstart/build-app, the current quickstart page for creating a new app (verified againstdocs.jsonnavigation, sinceapps/quickstart/only containsbuild-app.mdxanddeploy-on-base.mdx).Scope
This fixes the 2 highest-impact broken destination groups (75 of ~270 broken redirect entries found in the audit). The remaining ~105 unique broken destinations are documented in #1783, since several of them (particularly
/onchainkit/*and/smart-wallet/*legacy paths) may point to content intentionally moved out of this repo, and guessing at destinations for those risks introducing new incorrect redirects. Happy to open follow-up PRs once destinations are confirmed.Verification
docs.jsonvalidated as parseable JSON after the changenode scripts/lint-mdx.js allrun — no new errors introduced (this script doesn't checkdocs.jsonredirects, so the broken-redirect count itself isn't reflected there)