Skip to content

fix: use install_with_observer for B20Factory/PolicyRegistry precompiles #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stephancill wants to merge 1 commit into
base: base-anvil-fork
Choose a base branch
from
Open

fix: use install_with_observer for B20Factory/PolicyRegistry precompiles #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/evm/networks/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ alloy-primitives = { workspace = true, features = [
# github.com/base/base; bump via ./script/bump-base.sh. To iterate against a
# local base/base checkout instead, uncomment the [patch] block at the bottom
# of the workspace root Cargo.toml.
base-common-precompiles = { git = "https://github.com/base/base.git", rev = "401ffe4d60f3d0e9c34168c865521a3b186339df" }
base-common-chains = { git = "https://github.com/base/base.git", rev = "401ffe4d60f3d0e9c34168c865521a3b186339df" }
base-common-precompiles = { git = "https://github.com/base/base.git", rev = "cc8ee3860973c6a98823c63324e95ad9daf63e1b" }
base-common-chains = { git = "https://github.com/base/base.git", rev = "cc8ee3860973c6a98823c63324e95ad9daf63e1b" }

revm = { workspace = true, features = [
"std",
Expand Down
20 changes: 17 additions & 3 deletions crates/evm/networks/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ use alloy_primitives::{Address, U256, address, keccak256, map::AddressHashMap};
use base_common_chains::BaseUpgrade;
use base_common_precompiles::{
ActivationFeature, ActivationRegistry, ActivationRegistryStorage, B20Factory,
B20FactoryStorage, BerylLookup, PolicyRegistryPrecompile, PolicyRegistryStorage,
B20FactoryStorage, BerylLookup, NoopPrecompileCallObserver, PolicyRegistryPrecompile,
PolicyRegistryStorage,
};
use clap::Parser;
use serde::{Deserialize, Serialize};
Expand Down Expand Up @@ -165,10 +166,23 @@ impl NetworkConfigs {
// upgrade so each B-20 token resolves its logic version per-call
// (e.g. Stablecoin V1 at Beryl). Pinned to Beryl until `--base-fork`
// (BOP-428) makes the fork selectable at runtime.
//
// The factory/policy singletons use `install_with_observer` with a
// no-op observer, matching provider.rs; base/base dropped the plain
// `install` shims in favour of the observed variants. Metrics
// observation is scoped to the B-20 token call path, which anvil
// does not wire up, so a no-op observer is correct here.
let admin = Some(self.base_activation_admin());
B20Factory::install(precompiles);
B20Factory::install_with_observer(
precompiles,
BaseUpgrade::Beryl,
NoopPrecompileCallObserver,
);
BerylLookup::install(precompiles, BaseUpgrade::Beryl);
PolicyRegistryPrecompile::install(precompiles);
PolicyRegistryPrecompile::install_with_observer(
precompiles,
NoopPrecompileCallObserver,
);
ActivationRegistry::install(precompiles, admin);
}
}
Expand Down
Loading