fix: compute spam score off-lock to prevent input-dispatch ANR#590
Open
Letdown2491 wants to merge 1 commit into
Open
fix: compute spam score off-lock to prevent input-dispatch ANR#590Letdown2491 wants to merge 1 commit into
Letdown2491 wants to merge 1 commit into
Conversation
NotificationRepository.addEvent ran NSpamClassifier.score() inside synchronized(lock) via mergeKind1 -> mergeReply. Feature extraction runs several regex passes over up to ten notes per author; doing it under the lock stalls every caller -- including main-thread callers like getAllPostCardEventIds() and markRead -- past the 5s input-dispatch deadline. Fix: warmSpamScore(event) runs before the lock, computes the score under the same spamFilterEnabled/isFollowing/safelist/reply-target guards, and caches it in SpamAuthorCache (LruCache-backed, thread- safe). mergeReply now only consults the cache. Port of barrydeen/dark-wisp-android#23.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NotificationRepository.addEvent ran NSpamClassifier.score() inside synchronized(lock) via mergeKind1 -> mergeReply. Feature extraction runs several regex passes over up to ten notes per author; doing it under the lock stalls every caller -- including main-thread callers like getAllPostCardEventIds() and markRead -- past the 5s input-dispatch deadline.
Fix: warmSpamScore(event) runs before the lock, computes the score under the same spamFilterEnabled/isFollowing/safelist/reply-target guards, and caches it in SpamAuthorCache (LruCache-backed, thread- safe). mergeReply now only consults the cache.
Port of barrydeen/dark-wisp-android#23.