Add vertical scrolling for portrait outputs - #45
Merged
Merged
Conversation
Support main-axis layout overrides globally, per output and per workspace. Keep directional navigation physical and adapt gestures, resizing, overview and carousel rendering to vertical rows. Reuse shared geometry and existing config, sizing, animation and screenshot APIs. Adapted from 0WD0/niri wd/vertical-layout at 5b98189, with Biri integration, coordinate-boundary fixes, regression tests and documentation. Co-authored-by: 0WD0 <wd.1105848296@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Portrait outputs can now scroll windows vertically while landscape outputs retain horizontal scrolling. Set
main-axisglobally, per output or per named workspace; existing windows update on config reload.Directional focus and movement keep their screen directions. Column-width presets control row height in vertical mode, and window-height presets control width within a row. Workspace navigation, gestures and overview placement follow the layout axes.
The implementation shares axis conversion between layout and input, reuses the existing config/sizing/animation APIs, and shares live/carousel placement. It preserves Biri’s hidden workspaces, sticky drag handling, multi-action binds and Shift-wheel carousel navigation. Regression fixes cover struts, client bounds, tab indicators, resize metadata, animation offsets and the pointer anchor when a window detaches during dragging.
Adapted from 0WD0’s reference implementation at 5b981892. Addresses the request in niri#1071; the design also incorporates the directional-shortcut feedback on niri#1677. Research and design details are in the implementation notes.
Validation:
Live portrait-monitor/touchpad testing and the GTK visual-test application remain outstanding.