feat(detectors): Add transitive multi-hop taint propagation through intermediate tools (#10) - #18
Closed
IronLad123 wants to merge 5 commits into
Closed
Conversation
…ntermediate tools (bamdadd#10)
Owner
|
Thank you @IronLad123 - this is a substantial and well-executed feature. The transitive propagation is genuine data-flow tracking: an intermediate is only on the path if it actually carries the tainted segment (segment present in its input AND its output feeds forward), so independent tools don't create false positives. I verified the invariant holds: deterministic across repeated runs, the sanitized and no-carry two-hop fixtures both stay clean, and |
Owner
|
Merged via 29012d8. Thanks for the great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10
Summary
Adds transitive multi-hop taint propagation to
TaintDetectorinsrc/taintline/detectors/taint.py, enabling data-flow tracking through intermediate tool transformations (e.g.web_fetch->format_text->send_email).Rationale & Key Features
max_hops: int = 2onTaintConfig.Finding.span_idsnames every span on the path(source, inter_1, ..., sink), andFinding.messageformats the intermediate path explicitly (via intermediate tool(s) 'format_text').trace.in_order()with no clock, RNG, network, or iteration-order leakage.Verification
tests/fixtures/seeded/:taint_two_hop_positive.json(positive 2-hop flow)clean_two_hop_sanitized.json(sanitized 2-hop flow)clean_two_hop_negative.json(clean 2-hop flow with no carry)PYTHONHASHSEED=0andPYTHONHASHSEED=42.pytest: 56 / 56 passed (1.16s).ruff check: 0 errors.