Skip to content

Add EGL XCB keyboard and fix eglCreatePlatformWindowSurfaceEXT crash - #3934

Open
RobotLeopard86 wants to merge 1 commit into
baldurk:v1.xfrom
RobotLeopard86:v1.x
Open

RobotLeopard86 wants to merge 1 commit into
baldurk:v1.xfrom
RobotLeopard86:v1.x

Conversation

@RobotLeopard86

Copy link
Copy Markdown

Description

This PR fixes two issues that I encountered with RenderDoc while testing my application.

  1. The EGL driver now recognizes the use of XCB for windowing and configures keyboard input appropriately (previously, it only checked for Xlib and Wayland).
  2. The EGL hook layer now properly loads eglCreatePlatformWindowSurfaceEXT instead of forwarding it to eglCreatePlatformWindowSurface so that applications that load the extension (for a pre-EGL 1.5 install) will not crash.
    • In RenderDoc v1.46, eglCreatePlatformWindowSurfaceEXT was not hooked at all, so using it would mean your window would not be picked up by RenderDoc and you couldn't capture.
    • RenderDoc v1.47 added a hook, but redirected eglCreatePlatformWindowSurfaceEXT to plain eglCreatePlatformWindowSurface, so on systems where only the EXT version was available, the app would crash when the hook tried to call the unavailable "normal" version.

System Used for Testing

  • Dell Latitude 7450
  • Arch Linux with latest packages
  • Intel Mesa graphics driver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant