Skip to content
This repository was archived by the owner on Apr 14, 2026. It is now read-only.

ci: trigger dune upload - #301

Merged
Xeonus merged 2 commits into
biweekly-runsfrom
ci/trigger-dune-upload
Mar 3, 2026
Merged

ci: trigger dune upload#301
Xeonus merged 2 commits into
biweekly-runsfrom
ci/trigger-dune-upload

Conversation

@gosuto-inzasheru

Copy link
Copy Markdown
Collaborator

No description provided.

Comment on lines +12 to +20
runs-on: ubuntu-latest

steps:
- name: Trigger dune revenue upload
run: |
gh api repos/${{ secrets.DUNE_UPLOAD_REPO }}/dispatches \
-f event_type=recon-updated
env:
GH_TOKEN: ${{ secrets.DUNE_UPLOAD_TOKEN }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just add read perms?

@Xeonus Xeonus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth adding read perms to action?

Comment on lines +12 to +20
runs-on: ubuntu-latest

steps:
- name: Trigger dune revenue upload
run: |
gh api repos/${{ secrets.DUNE_UPLOAD_REPO }}/dispatches \
-f event_type=recon-updated
env:
GH_TOKEN: ${{ secrets.DUNE_UPLOAD_TOKEN }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just add read perms?

@gosuto-inzasheru

Copy link
Copy Markdown
Collaborator Author

@Xeonus why? this only triggers and afaiu doesnt even require read perms

there is however an empty perms block to make this explicit: 4939f6a

@Xeonus Xeonus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, no read perms needed but empty block for best practice / get rid of GH warning

@Xeonus
Xeonus merged commit f585062 into biweekly-runs Mar 3, 2026
4 checks passed
@Xeonus
Xeonus deleted the ci/trigger-dune-upload branch March 3, 2026 08:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants