UI improves | Feedback from BD team - #5
Open
gustavobftorres wants to merge 7 commits into
Open
Conversation
…n and unit tests to see all possible cases (for a protocol approach)
…final demand value
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI changes made (LBP Simulator)
1) Sales tab: swaps counter in the green info bar
What changed
Swaps: <count>.What it means
Where
components/lbp-simulator/simulator/SimulatorMain.tsx2) Green info bar: text spacing + alignment
What changed
gapso spacing does not depend on JSX whitespace.Where
components/lbp-simulator/simulator/SimulatorMain.tsx3) Weights: numeric input next to sliders
What changed
Behavior
1..99and rounded to integers (same as the slider step).Where
components/lbp-simulator/simulator/SimulatorConfig.tsx4) Buy pressure: single “End cumulative buy (target)” input
Problem
magnitudeBase(10k / 100k / 1M) ×multiplierWhat changed
magnitudeBase+multiplier, but the UI auto-picks a sensible base and computes a multiplier.Presets
Where
components/lbp-simulator/simulator/DemandPressureConfig.tsx5) Buy pressure target input: formatted numbers (commas)
What changed
100,000) on blur / when not actively editing, similar to the Total Supply input UX.Where
components/lbp-simulator/simulator/DemandPressureConfig.tsx6) Token logos: USDC/USDT inline SVG (no remote fetch)
What changed
next/imageremote SVG restrictions.Where
components/ui/TokenLogo.tsx