Skip to content

feat: add queries that are dependencies for other balancer queries - #3

Merged
gustavobftorres merged 1 commit into
mainfrom
@gustavo/feat/queries-dependencies
Mar 27, 2026
Merged

gustavobftorres merged 1 commit into
mainfrom
@gustavo/feat/queries-dependencies

Conversation

@gustavobftorres

Copy link
Copy Markdown
Collaborator

Is this linked to an existing issue?
N/A (Phase 4 dependency resolution checkpoint)

Fill out the following table describing your edits:

Original Updated Change Reasoning
Unresolved query_{id} references across imported SQL balancer/views/*.sql + queries.yml (category: views) Imported shared dependency queries (including recursive deps) and registered them in manifest Ensure dependency closure so repo SQL is self-consistent and easier to maintain
No dependency inventory doc docs/DEPENDENCIES.md Added dependency resolution summary + imported view list + external schema dependency inventory Provide auditable dependency map before moving to next phases
validate.py showed unresolved deps validate.py output after imports Reduced unresolved dependency warnings to zero and reached All checks passed. Confirm Phase 4 dependency-resolution objective is complete

Provide any other context or screenshots that explain or justify the changes above:

  • Phase 4 focuses on query-to-query dependency closure, not full SQLFluff debt elimination.
  • Dependency imports include API fallback for edge-case query payload parsing.
  • Final consistency check: python scripts/validate.py -> All checks passed.

Checklist:

  • SQL file name follows descriptive_name_{queryId}.sql convention
  • File includes -- part of a query repo header
  • Query ID is listed in queries.yml
  • SQLFluff passes locally (sqlfluff lint <file>) (full-repo legacy debt tracked separately)
  • If adding a new query: created on dune.com first, then added to repo
  • If adding new Jinja parameters: updated the relevant .sqlfluff context

…DEPENDENCIES.md file on docs folder to map all those connections
@github-actions

Copy link
Copy Markdown

Are you sure you want to use the legacy prices.usd table? Consider using prices.minute (docs)


Caused by:

@gustavobftorres
gustavobftorres merged commit 41f98d6 into main Mar 27, 2026
1 of 2 checks passed
@gustavobftorres
gustavobftorres deleted the @gustavo/feat/queries-dependencies branch March 27, 2026 18:09
gustavobftorres added a commit that referenced this pull request Apr 15, 2026
…ndencies

feat: add queries that are dependencies for other balancer queries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant