chore: fix array parsing from balancer/backend - #171
Merged
Conversation
What was wrong _to_json only rewrote spreads of inline array literals (...[ ] → [ ]). When balancer/backend added workerJobs: [...activeChainWorkerJobsGeneric, ...] (spreads of imported identifiers), those tokens reached json.loads and raised JSONDecodeError for every chain. Subgraph.get_subgraph_url_from_backend_config() swallowed it (bare try/except → None) and silently fell back to stale studio.thegraph.com URLs — which regressed the bal_addresses scheduled PR with outdated sources This change fixes the issue by adding two regexes right before the existing one to properly handle the new data structure in the backend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
_to_json only rewrote spreads of inline array literals (...[ ] → [ ]). When balancer/backend added workerJobs: [...activeChainWorkerJobsGeneric, ...] (spreads of imported identifiers), those tokens
reached json.loads and raised JSONDecodeError for every chain. Subgraph.get_subgraph_url_from_backend_config() swallowed it (bare try/except → None) and silently fell back to stale
studio.thegraph.com URLs — which regressed the bal_addresses scheduled PR with outdated sources
Fix
This change fixes the issue by adding two regexes right before the existing one to properly handle the new data structure in the backend.