Conversation
Contributor
|
- all paths for this base route is not in use, so checking for the enum here does not help users. - i think this is a better appraoch then adding the routeEnum param to retiredService at this
Member
Author
|
i completely removed the Enum from SwaggerRedirect here which is a retired service for the /2.0 base
|
Member
Author
|
This one is pretty fun bug. The main problem we are going to have solving this, is backwards compatibility. My guess is that one overides the other so i could make change the base for the one that was overriden then use a redirect for all enum values other then the one that was not in use.... |
Member
Author
|
oh, it's not a conflict, one has a user param later and the other doesnt. |
Member
Author
|
migrated to #12173 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follo-up of #11800 & a condition for #11371
im going to push today some groups with a few services each for easier review.