add priorityClassName support for controller on helm chart - #2097
add priorityClassName support for controller on helm chart#2097JohnMastodon wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JohnMastodon The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @JohnMastodon. Thanks for your PR. I'm waiting for a backube member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
a9fb1dc to
46c3c84
Compare
| {{- toYaml . | nindent 8 }} | ||
| {{- end }} | ||
| {{- with .Values.priorityClassName }} | ||
| priorityClassName: {{ . }} |
There was a problem hiding this comment.
| priorityClassName: {{ . }} | |
| priorityClassName: {{ . | quote }} |
Could we quote just to ensure we get a string value?
There was a problem hiding this comment.
@JohnMastodon Thanks for this PR - I just have one small comment above - also, you will need to make sure you sign your commit - see: https://github.com/backube/volsync/pull/2097/checks?check_run_id=102285384157
There was a problem hiding this comment.
@tesshuflower Thanks for the feedback, I included your suggestion in the commit and signed it
Signed-off-by: John Mastodon <121522530+JohnMastodon@users.noreply.github.com>
46c3c84 to
69b0033
Compare
|
2 participants
Describe what this PR does
adds priorityClassName support in helm chart for the controller pod
Is there anything that requires special attention?
Related issues:
closes #2095