Skip to content

BREAKING: Split Valibot Schema to Its Own Package - #863

Merged
bachmacintosh merged 3 commits into
v3from
split-valibot
Oct 2, 2026
Merged

bachmacintosh merged 3 commits into
v3from
split-valibot

Conversation

@bachmacintosh

Copy link
Copy Markdown
Collaborator

Description

This PR splits all valibot related schema definitions to a new wanikani-api-valibot package. The test suite has also been updated, with reusable fixtures for when we code the remaining schema library packages.

Nature of Pull Request

This Pull Request:

  • Adds/Updates Type(s)/Schemas
  • Adds/Updates Helper Functions/Type Guards
  • Updates Documentation
  • Updates Project and/or Community Health files (e.g. README, GitHub Actions, etc.)

Its changes constitutes a:

  • Non-code change (i.e. no version bump)
  • Bug Fix or Other Small Changes (i.e. patch version bump)
  • Forward-compatible Enhancement (i.e. minor version bump)
  • ⚠️ BREAKING CHANGE regarding TypeScript, Package, and/or WaniKani API version(s) (i.e. MAJOR version bump)

Contribution Terms

I understand that by submitting this Pull Request:

Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
@bachmacintosh bachmacintosh added breaking change A breaking change that will require a major version bump types Issues/PRs pertaining to the `wanikani-api-types` package labels Oct 2, 2026
@codecov

codecov Bot commented Oct 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
packages/requests/src/v20170710/parameters.ts 100.00% <100.00%> (ø)
packages/types/src/v20170710/base.ts 100.00% <ø> (ø)
...s/types/src/v20170710/spaced-repetition-systems.ts 100.00% <ø> (ø)
packages/types/src/v20170710/user.ts 100.00% <ø> (ø)
packages/valibot/src/v20170710/assignments.ts 100.00% <100.00%> (ø)
packages/valibot/src/v20170710/base.ts 100.00% <100.00%> (ø)
...ckages/valibot/src/v20170710/level-progressions.ts 100.00% <100.00%> (ø)
packages/valibot/src/v20170710/resets.ts 100.00% <100.00%> (ø)
...ackages/valibot/src/v20170710/review-statistics.ts 100.00% <100.00%> (ø)
packages/valibot/src/v20170710/reviews.ts 100.00% <100.00%> (ø)
... and 6 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
@bachmacintosh
bachmacintosh added this pull request to the merge queue Oct 2, 2026
Merged via the queue into v3 with commit 363152d Oct 2, 2026
5 checks passed
@bachmacintosh
bachmacintosh deleted the split-valibot branch October 2, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change A breaking change that will require a major version bump types Issues/PRs pertaining to the `wanikani-api-types` package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant