Repository navigation
feat(AF-1027): verification settings, timeline stage and samples UI - #1236
Merged
Merged
Conversation
Environment modal gains a post-deployment verification section (HTTP and PromQL checks, client rules mirroring #1023/#1024). The deployment detail page shows a verification row, card with the config snapshot and samples, a timeline stage after the outcome, and a did-not-roll-back callout on a breach; the list tags the verification status. The request response now carries verification_snapshot (window, interval, threshold, check count — no check targets). New e2e spec drives a breach against WireMock.
Name the failed rule of a 422 DEPLOYMENT_VERIFICATION_INVALID from its reason/checkName (its detail is generic); mirror the userinfo and Prometheus query/fragment rules client-side; refetch samples when the window closes; outcome-aware breach callout after ROLLED_BACK; translate SKIPPED tokens and hide the empty card; hide SKIPPED in the list; pin the snapshot wire shape; doc wording fixes.
Contributor
Contributor
Coverage Report for Frontend Coverage (frontend)
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
Contributor
Backend Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1027 (part of epic #1022).
What
Makes post-deployment verification configurable and visible in the web UI. The UI decides nothing and never says AccessFlow rolled anything back.
PipelineEnvironmentsTab): a Post-deployment verification section. A switch reveals window / interval / failure threshold and up to ten checks; a check-typeSelect(notSegmented) swaps the HTTP fields (URL, expected status, body contains) for the PromQL ones (Prometheus URL, query, comparator, threshold, no-data switch). Turning it off sendsverification: nullon create andclear_verification: trueon edit. A Verification column shows the check count. Pure form logic and client rules are in the newverificationForm.ts.detailforDEPLOYMENT_VERIFICATION_INVALIDis one generic sentence, so the form turnsreason+checkNameinto a translated message that names the failed rule (unknown reason → server detail).RUNNING, plus one more samples fetch when the window closes;FAILED+SUCCEEDED) shows "verification failed — the release is still running … AccessFlow did not roll back". Once the pipeline reportsROLLED_BACK, the callout says that instead. The release stage keeps reading as released;SKIPPEDmachine tokens (no verification configured,outcome:FAILED) are translated, and a request that was never sampled gets no card.SKIPPEDleft out — see Review notes).verification_snapshot—window,sample_interval,failure_threshold,check_count— decoded from the existingdeployment_requests.verification_config, fail-soft to null. It deliberately carries no check names, URLs or queries: request detail is readable by submitters and reviewers, while environment config is admin-only.t(), all seven locales.Validation parity
The form mirrors
DeploymentVerificationConfigRequest/DeploymentVerificationCheckRequestand the network-free #1024 rules:user:password@; no query or fragment on a Prometheus URL;Host policy (resolution, restricted addresses, allow-list) is server-only.
Docs
docs/04-api-spec.md—verification_snapshoton request detail and list bodies (not the gate).docs/06-frontend.md— list, detail and Environments-tab rows.docs/18-deployment-governance.md— "In the web UI (frontend: environment verification settings and verification timeline #1027)".help-corpus/regenerated.Tests
mvn verifygreen (12,173 tests). New service tests (snapshot present / absent / unreadable) and response-mapping + snake_case wire-shape tests.test:coverage— 3,236 tests, 96.7 % lines / 89.8 % branches. NewverificationForm.test.ts; extended tab, timeline, detail, list, enum-label, color and API tests.deployment-verification.spec.ts, plus the existing deployment-pipelines / versions / review specs — 19/19 locally on a rebuilt stack.ACCESSFLOW_DEPLOYGOV_VERIFICATION_CHECK: PT5Sadded to the e2e backend.Deviations from the issue
http://mock-ai:8080/verification-health(WireMock 404) instead ofhttp://verification.invalid/health, which the save-timehost_unresolvablerule would refuse.RUNNINGstage (step 10b): with a 5 s job tick it usually ends before the page loads. Unit tests coverRUNNING.SKIPPED: it would tag every deploy to an environment with no checks (seen in a capture). The detail page and timeline still show it.Review notes
Five read-only reviewers ran (verifier, cross-cutting, Java, frontend, content). No blockers. Fixed from their findings:
ROLLED_BACK(content / frontend);SKIPPEDtokens (frontend);Concerns left open:
dependencieson sibling rows, so a stale duplicate-name error can linger on the other row until the next save.verificationoption is typedRecord<string, unknown>, so a wire-key typo isn't caught at compile time.Screenshots