Repository navigation
feat(AF-1026): deployment verification-failed notifications and audit - #1235
Merged
babltiga merged 2 commits intoNov 11, 2026
Merged
Conversation
Contributor
Contributor
Backend Code Coverage
|
Contributor
Frontend Test Results 1 files 360 suites 10m 24s ⏱️ Results for commit 18e927e. |
Contributor
Coverage Report for Frontend Coverage (frontend)
File Coverage
|
||||||||||||||||||||||||||||||||||||||
babltiga
deleted the
feature/AF-1026-deploygov-verification-notifications
branch
November 11, 2026 06:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1026 (part of epic #1022).
What
A breached post-deployment verification (#1025) used to flip the request
EXECUTED → FAILEDwithout telling anyone. This change notifies the people who can act on it and records the breach in the audit log.DEPLOYMENT_VERIFICATION_FAILEDAuditActionis written byDeploymentRequestStateService.markVerificationFailed. It is a system row: the actor is null andtrigger=verification. Metadata holdspipeline_id,version,checkanddetail;checkis left out when the config snapshot could not be read.markVerificationFailednow also takes the check name.DEPLOYMENT_VERIFICATION_FAILEDNotificationEventTypegoes to the reviewers who approved the deployment plus the submitter. Duplicates are removed and inactive users dropped. A request with no approvers (auto-approved or break-glass) notifies the submitter alone.PagerDutyTriggerandTicketingTriggerdo not map it; tests pin that.email/deployment-verification-failed.html, is wired into all three switches in the email strategy. Its keys are in all sevenmessages*.propertiesfiles.DeploymentVerificationText.deployment.decision_reason.verification_detailfield, so the bell names the failed check./deployments/{id}, never to the rollback worklist, because nothing was rolled back.notification.createdfor this event refreshes the deployment detail and list queries.docs/08-notifications.md,docs/18-deployment-governance.md,docs/03-data-model.md,docs/05-backend.md,docs/04-api-spec.mdanddocs/06-frontend.md.help-corpus/was regenerated becauseen.jsonchanged.No migration.
audit_log.actionanduser_notifications.event_typeare both VARCHAR.Website: no change. No website page lists deployment notification events, and the epic's website sweep is #1028.
E2E: none added. No existing flow changes behaviour. The verification UI and its spec are #1027.
Screenshots: none. The only UI change is the text of one bell entry.
Verification
mvn -o verifyon the first commit: 12,169 tests, 0 failures, 6 skipped. It ran before the review fixes in the second commit. The 291 backend tests those fixes touch were re-run afterwards and pass, includingApplicationModulesTestandMessagesParityTest.npm run lintpasses with 0 errors (warnings were already there).npm run typecheckandnpm run buildpass.npm run test:coverage: 3,187 tests pass, with 96.7% line and 89.5% branch coverage.node .github/scripts/build-help-corpus.mjsproduces no further changes when re-run.Review notes
Five read-only reviewers (verifier, cross-cutting, Java, frontend, content) ran in parallel. None found a blocker. The fixes for their concerns are in the second commit:
verification_detail. The audit-action reference indocs/03and the paragraph indocs/05also needed the new action.docs/08described the detail format wrongly and didn't mention the unreadable-config message; both are fixed.Concerns left open for a human reviewer:
<check>: <failed>/<failure_threshold> failed samples, and at breach time it is usually "3/3". That can be read as "every sample failed". The format comes from deploygov: DeploymentVerificationJob — window, sampling and breach → FAILED #1025 and is part of the documented API (verification_detailindocs/04/docs/05), so I kept it and spelled out the meaning indocs/08. Rewording it is a possible follow-up.on_behalf_of_user_id. This matches the design agreed on the issue and the existing APPROVED/REJECTED behaviour. Notifying that person is a possible follow-up.